knopersikcuo/Planner
Watch
1
0
Fork
You've already forked Planner
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix memory hook notification compatibility and routing #130

Merged
kleb merged 1 commit from fix/memory-hook-compatibility into main 2026-09-07 09:58:29 +02:00
Conversation 1 Commits 1 Files changed 13 +350 -97
kleb commented 2026-09-07 09:57:52 +02:00
Collaborator
Copy link

Changes

  • Treat notification task IDs as opaque and suppress summary-only machine notifications across ingress boundaries.
  • Clarify explicit-system tool routing and memory/work project identifiers.
  • Guide finalization callers to omit unnecessary versions while preserving strict conflicts.
  • Add opt-in payload-free hook phase timings on stderr.

Verification

  • 54 focused tests across 8 files passed.
  • Typecheck, targeted type-aware lint, formatting, and diff checks passed.
  • No retrieval-policy changes or persisted-data changes.
## Changes - Treat notification task IDs as opaque and suppress summary-only machine notifications across ingress boundaries. - Clarify explicit-system tool routing and memory/work project identifiers. - Guide finalization callers to omit unnecessary versions while preserving strict conflicts. - Add opt-in payload-free hook phase timings on stderr. ## Verification - 54 focused tests across 8 files passed. - Typecheck, targeted type-aware lint, formatting, and diff checks passed. - No retrieval-policy changes or persisted-data changes.
kAgent commented 2026-09-07 09:57:53 +02:00
Collaborator
Copy link

kReview review

Verdict: no findings

The visible changes appear low risk; no concrete correctness, security, or regression issue is established by the supplied evidence.

Reviewed by kReview at 5d3c50742f. This comment is conservative and based only on the PR diff, metadata, and supplied repository context.

Est. cost ~$0.39 (42.7k in / 136 out / gpt-6-astra).

<!-- codex-forgejo-review --> <!-- codex-forgejo-review-head:5d3c50742f23a9e6ac97bced4c642864e694c074 --> <!-- codex-forgejo-review-comparison:v1:a29f323607cc2537e13208b59b0ecdd58be64e3a7d3d57ac4def269ac3c54a8a --> ## kReview review **Verdict:** no findings The visible changes appear low risk; no concrete correctness, security, or regression issue is established by the supplied evidence. _Reviewed by kReview at `5d3c50742f`. This comment is conservative and based only on the PR diff, metadata, and supplied repository context._ _Est. cost ~$0.39 (42.7k in / 136 out / gpt-6-astra)._ <!-- codex-forgejo-review-state:eyJoZWFkU2hhIjoiNWQzYzUwNzQyZjIzYTllNmFjOTdiY2VkNGM2NDI4NjRlNjk0YzA3NCIsImNvbXBhcmlzb25LZXkiOiJ2MTphMjlmMzIzNjA3Y2MyNTM3ZTEzMjA4YjU5YjBlY2RkNThiZTY0ZTNhN2QzZDU3YWM0ZGVmMjY5YWMzYzU0YThhIiwic3VtbWFyeSI6IlRoZSB2aXNpYmxlIGNoYW5nZXMgYXBwZWFyIGxvdyByaXNrOyBubyBjb25jcmV0ZSBjb3JyZWN0bmVzcywgc2VjdXJpdHksIG9yIHJlZ3Jlc3Npb24gaXNzdWUgaXMgZXN0YWJsaXNoZWQgYnkgdGhlIHN1cHBsaWVkIGV2aWRlbmNlLiIsImZpbmRpbmdzIjpbXSwiY3VtdWxhdGl2ZUNvc3QiOnsidXNkIjowLjM5NDU5MiwiaW5wdXRUb2tlbnMiOjQyNjk2LCJvdXRwdXRUb2tlbnMiOjEzNiwibW9kZWwiOiJncHQtNi1hc3RyYSJ9fQ== -->
kleb merged commit e7b8d6ebfc into main 2026-09-07 09:58:29 +02:00
kleb deleted branch fix/memory-hook-compatibility 2026-09-07 09:58:29 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
knopersikcuo/Planner!130
No description provided.