kleb/SpotifFLAC
Watch
1
0
Fork
You've already forked SpotifFLAC
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Harden download file handling and IPC #6

Merged
kleb merged 1 commit from codex/audit-hardening-fixes into main 2026-06-30 07:53:06 +02:00
Conversation 1 Commits 1 Files changed 15 +802 -585
kleb commented 2026-06-30 07:50:07 +02:00
Owner
Copy link

Summary:

  • prevent wrong-file skips/deletes on filename collisions
  • make FLAC metadata rewrites atomic and fail downloads when final tagging fails
  • centralize output filename construction and harden IPC/navigation checks
  • redact Qobuz stream response logging
  • add regression tests for filename/collision behavior

Validation:

  • bun run typecheck
  • bun run lint
  • bun run test
Summary: - prevent wrong-file skips/deletes on filename collisions - make FLAC metadata rewrites atomic and fail downloads when final tagging fails - centralize output filename construction and harden IPC/navigation checks - redact Qobuz stream response logging - add regression tests for filename/collision behavior Validation: - bun run typecheck - bun run lint - bun run test
kAgent commented 2026-06-30 07:50:09 +02:00
Collaborator
Copy link

kReview review

Verdict: no findings

No findings to address in the reviewed diff.

Overall risk is low; the changes are mostly defensive and no concrete runtime regression is evident from the reviewed diff.

Reviewed by kReview at f873ed8a76. This comment is conservative and based only on the PR diff, metadata, and supplied repository context.

Est. cost ~$0.27 (51.9k in / 557 out / gpt-5.5).

<!-- codex-forgejo-review --> <!-- codex-forgejo-review-head:f873ed8a76545b76dc6f8f976addf2a6a13fe22d --> ## kReview review **Verdict:** no findings No findings to address in the reviewed diff. Overall risk is low; the changes are mostly defensive and no concrete runtime regression is evident from the reviewed diff. _Reviewed by kReview at `f873ed8a76`. This comment is conservative and based only on the PR diff, metadata, and supplied repository context._ _Est. cost ~$0.27 (51.9k in / 557 out / gpt-5.5)._ <!-- codex-forgejo-review-state:eyJoZWFkU2hhIjoiZjg3M2VkOGE3NjU0NWI3NmRjNmY4Zjk3NmFkZGYyYTZhMTNmZTIyZCIsInN1bW1hcnkiOiJPdmVyYWxsIHJpc2sgaXMgbG93OyB0aGUgY2hhbmdlcyBhcmUgbW9zdGx5IGRlZmVuc2l2ZSBhbmQgbm8gY29uY3JldGUgcnVudGltZSByZWdyZXNzaW9uIGlzIGV2aWRlbnQgZnJvbSB0aGUgcmV2aWV3ZWQgZGlmZi4iLCJmaW5kaW5ncyI6W10sImN1bXVsYXRpdmVDb3N0Ijp7InVzZCI6MC4yNjUzOTEsImlucHV0VG9rZW5zIjo1MTkyNSwib3V0cHV0VG9rZW5zIjo1NTcsIm1vZGVsIjoiZ3B0LTUuNSJ9fQ== -->
kleb merged commit 91513a4bab into main 2026-06-30 07:53:06 +02:00
kleb deleted branch codex/audit-hardening-fixes 2026-06-30 07:54:01 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
kleb/SpotifFLAC!6
No description provided.