Fix cross-platform ffmpeg recovery #3

Merged
kleb merged 1 commit from fix/cross-os-ffmpeg-recovery into main 2026-06-17 23:49:01 +02:00
Owner

Purpose

Fix ffmpeg dependency recovery across supported platforms and avoid relying on inherited PATH state.

Key changes

  • Add a central ffmpeg resolver/installer with managed Windows, macOS, and Linux targets.
  • Route recording, device detection, and audio-file conversion through the resolved absolute ffmpeg path.
  • Add install recovery actions to the setup flow and missing-dependency UI.
  • Add focused ffmpeg tests and third-party notices.

Verification

  • bun run test
  • bun run build
  • cd ui && bun run lint
## Purpose Fix ffmpeg dependency recovery across supported platforms and avoid relying on inherited PATH state. ## Key changes - Add a central ffmpeg resolver/installer with managed Windows, macOS, and Linux targets. - Route recording, device detection, and audio-file conversion through the resolved absolute ffmpeg path. - Add install recovery actions to the setup flow and missing-dependency UI. - Add focused ffmpeg tests and third-party notices. ## Verification - bun run test - bun run build - cd ui && bun run lint
Collaborator

kReview review

Verdict: no findings

No findings to address in the reviewed diff.

Overall risk is low; no concrete correctness or security regression is provable from the supplied diff and context.

Excluded as generated or vendored (not reviewed): bun.lock.

Reviewed by kReview at 0a7fca95d5. This comment is conservative and based only on the PR diff, metadata, and supplied repository context.

Est. cost ~$0.23 (43.9k in / 556 out / gpt-5.5).

<!-- codex-forgejo-review --> <!-- codex-forgejo-review-head:0a7fca95d537f397a32daecc451ddc4bb4fd0438 --> ## kReview review **Verdict:** no findings No findings to address in the reviewed diff. Overall risk is low; no concrete correctness or security regression is provable from the supplied diff and context. _Excluded as generated or vendored (not reviewed):_ `bun.lock`. _Reviewed by kReview at `0a7fca95d5`. This comment is conservative and based only on the PR diff, metadata, and supplied repository context._ _Est. cost ~$0.23 (43.9k in / 556 out / gpt-5.5)._ <!-- codex-forgejo-review-state:eyJoZWFkU2hhIjoiMGE3ZmNhOTVkNTM3ZjM5N2EzMmRhZWNjNDUxZGRjNGJiNGZkMDQzOCIsInN1bW1hcnkiOiJPdmVyYWxsIHJpc2sgaXMgbG93OyBubyBjb25jcmV0ZSBjb3JyZWN0bmVzcyBvciBzZWN1cml0eSByZWdyZXNzaW9uIGlzIHByb3ZhYmxlIGZyb20gdGhlIHN1cHBsaWVkIGRpZmYgYW5kIGNvbnRleHQuIiwiZmluZGluZ3MiOltdLCJjdW11bGF0aXZlQ29zdCI6eyJ1c2QiOjAuMjI1MDY2LCJpbnB1dFRva2VucyI6NDM4NjYsIm91dHB1dFRva2VucyI6NTU2LCJtb2RlbCI6ImdwdC01LjUifX0= -->
kleb merged commit 06a8756417 into main 2026-06-17 23:49:01 +02:00
kleb deleted branch fix/cross-os-ffmpeg-recovery 2026-06-17 23:49:01 +02:00
kleb referenced this pull request from a commit 2026-06-17 23:49:01 +02:00
kleb referenced this pull request from a commit 2026-08-24 01:37:05 +02:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
kleb/VoiceTyper!3
No description provided.