knopersikcuo/Planner
Watch
1
0
Fork
You've already forked Planner
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix shared note workspace layout #110

Closed
kleb wants to merge 0 commits from fix/shared-note-layout into main
pull from: fix/shared-note-layout
merge into: knopersikcuo:main
Conversation 1 Commits - Files changed - +35 -19
kleb commented 2026-08-23 20:00:19 +02:00
Collaborator
Copy link

Summary

  • keep shared-note metadata and the editor inside one CSS grid item
  • let the editor fill the remaining detail-pane height
  • add component and real account-sharing layout regression coverage
  • harden the sharing fixture against ambiguous Notepad controls and onboarding races

Verification

  • bun run typecheck
  • focused type-aware Oxlint, React lint, Oxfmt, and Impeccable detector
  • 13 focused Vitest tests
  • desktop account note/project sharing Playwright flow
  • bun run build:web and bundle budget
## Summary - keep shared-note metadata and the editor inside one CSS grid item - let the editor fill the remaining detail-pane height - add component and real account-sharing layout regression coverage - harden the sharing fixture against ambiguous Notepad controls and onboarding races ## Verification - `bun run typecheck` - focused type-aware Oxlint, React lint, Oxfmt, and Impeccable detector - 13 focused Vitest tests - desktop account note/project sharing Playwright flow - `bun run build:web` and bundle budget
kAgent commented 2026-08-23 20:00:20 +02:00
Collaborator
Copy link

kReview review

Verdict: no findings

No findings to address in the reviewed diff.

No meaningful correctness, security, layout, or test-fixture regressions are established by the visible changes.

Reviewed by kReview at f50a6fd987. This comment is conservative and based only on the PR diff, metadata, and supplied repository context.

Est. cost ~$1.36 (991.7k in / 2.4k out / gpt-5.6-sol).

<!-- codex-forgejo-review --> <!-- codex-forgejo-review-head:f50a6fd987083f9043ef5c153fde9badbc8e0e63 --> ## kReview review **Verdict:** no findings No findings to address in the reviewed diff. No meaningful correctness, security, layout, or test-fixture regressions are established by the visible changes. _Reviewed by kReview at `f50a6fd987`. This comment is conservative and based only on the PR diff, metadata, and supplied repository context._ _Est. cost ~$1.36 (991.7k in / 2.4k out / gpt-5.6-sol)._ <!-- codex-forgejo-review-state:eyJoZWFkU2hhIjoiZjUwYTZmZDk4NzA4M2Y5MDQzZWY1YzE1M2ZkZTliYWRiYzhlMGU2MyIsInN1bW1hcnkiOiJObyBtZWFuaW5nZnVsIGNvcnJlY3RuZXNzLCBzZWN1cml0eSwgbGF5b3V0LCBvciB0ZXN0LWZpeHR1cmUgcmVncmVzc2lvbnMgYXJlIGVzdGFibGlzaGVkIGJ5IHRoZSB2aXNpYmxlIGNoYW5nZXMuIiwiZmluZGluZ3MiOltdLCJjdW11bGF0aXZlQ29zdCI6eyJ1c2QiOjEuMzU3MjQzLCJpbnB1dFRva2VucyI6OTkxNzI1LCJvdXRwdXRUb2tlbnMiOjIzNjUsIm1vZGVsIjoiZ3B0LTUuNi1zb2wifX0= -->
kleb closed this pull request 2026-08-23 20:03:30 +02:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
knopersikcuo/Planner!110
No description provided.