knopersikcuo/Planner
Watch
1
0
Fork
You've already forked Planner
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Move feedback into its own settings tab #113

Merged
kleb merged 1 commit from feature/settings-feedback-tab into main 2026-08-24 21:51:41 +02:00
Conversation 1 Commits 1 Files changed 8 +84 -51
kleb commented 2026-08-24 21:50:29 +02:00
Collaborator
Copy link

Summary

  • move the feedback form out of General into a first-class Settings tab
  • hide the tab when the instance has no configured feedback destination
  • use a dedicated Close footer for the independently submitted form
  • localize the form heading in English, German, and Polish

Verification

  • 9 focused Vitest tests
  • 12 i18n Bun tests
  • TypeScript typecheck
  • targeted Oxlint and React ESLint
  • Oxfmt, git diff check, and Impeccable detector
## Summary - move the feedback form out of General into a first-class Settings tab - hide the tab when the instance has no configured feedback destination - use a dedicated Close footer for the independently submitted form - localize the form heading in English, German, and Polish ## Verification - 9 focused Vitest tests - 12 i18n Bun tests - TypeScript typecheck - targeted Oxlint and React ESLint - Oxfmt, git diff check, and Impeccable detector
kAgent commented 2026-08-24 21:50:29 +02:00
Collaborator
Copy link

kReview review

Verdict: no findings

No findings to address in the reviewed diff.

No findings to address across the reviewed diff.

Reviewed by kReview at 84f2231170. This comment is conservative and based only on the PR diff, metadata, and supplied repository context.

Est. cost ~$0.39 (122.6k in / 1.3k out / gpt-5.6-sol + gpt-5.6-terra).

<!-- codex-forgejo-review --> <!-- codex-forgejo-review-head:84f2231170f4650f12d0d3fdf7538a8bf701dd9a --> ## kReview review **Verdict:** no findings No findings to address in the reviewed diff. No findings to address across the reviewed diff. _Reviewed by kReview at `84f2231170`. This comment is conservative and based only on the PR diff, metadata, and supplied repository context._ _Est. cost ~$0.39 (122.6k in / 1.3k out / gpt-5.6-sol + gpt-5.6-terra)._ <!-- codex-forgejo-review-state:eyJoZWFkU2hhIjoiODRmMjIzMTE3MGY0NjUwZjEyZDBkM2ZkZjc1MzhhOGJmNzAxZGQ5YSIsInN1bW1hcnkiOiJObyBmaW5kaW5ncyB0byBhZGRyZXNzIGFjcm9zcyB0aGUgcmV2aWV3ZWQgZGlmZi4iLCJmaW5kaW5ncyI6W10sImN1bXVsYXRpdmVDb3N0Ijp7InVzZCI6MC4zODgzNzI5OTk5OTk5OTk5NywiaW5wdXRUb2tlbnMiOjEyMjYyMywib3V0cHV0VG9rZW5zIjoxMjgzLCJtb2RlbCI6ImdwdC01LjYtc29sICsgZ3B0LTUuNi10ZXJyYSJ9fQ== -->
kleb merged commit 431e3ace48 into main 2026-08-24 21:51:41 +02:00
kleb deleted branch feature/settings-feedback-tab 2026-08-24 21:51:41 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
knopersikcuo/Planner!113
No description provided.