knopersikcuo/Planner
Watch
1
0
Fork
You've already forked Planner
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Clarify memory session resume control #127

Merged
kleb merged 1 commit from feature/harden-memory-session-resume into main 2026-08-30 15:48:36 +02:00
Conversation 1 Commits 1 Files changed 2 +20 -8
kleb commented 2026-08-30 15:47:26 +02:00
Collaborator
Copy link

Summary

  • distinguish session creation from resuming paused memory in the MCP catalog
  • return the resulting paused state from the unified pause/resume control
  • cover readable and write-only token responses in focused MCP tests

Validation

  • bun test tests/memory-vocabulary.test.ts tests/agent-skill-mcp.test.ts --isolate --parallel=1 --timeout=30000
  • bun run typecheck
  • targeted Oxlint and Oxfmt checks
  • five isolated claude -p --model sonnet resume trials: 5/5 passed, one MCP call per run, no failures or retries
  • twenty isolated Luna resume trials: 20/20 passed across the retained and rejected wording variants
## Summary - distinguish session creation from resuming paused memory in the MCP catalog - return the resulting `paused` state from the unified pause/resume control - cover readable and write-only token responses in focused MCP tests ## Validation - `bun test tests/memory-vocabulary.test.ts tests/agent-skill-mcp.test.ts --isolate --parallel=1 --timeout=30000` - `bun run typecheck` - targeted Oxlint and Oxfmt checks - five isolated `claude -p --model sonnet` resume trials: 5/5 passed, one MCP call per run, no failures or retries - twenty isolated Luna resume trials: 20/20 passed across the retained and rejected wording variants
kAgent commented 2026-08-30 15:47:26 +02:00
Collaborator
Copy link

kReview review

Verdict: no findings

Low risk: the changed pause/resume result reflects the state guaranteed by the successful endpoint, and no concrete regression is established by the visible diff or repository evidence.

Reviewed by kReview at bdf06483e1. This comment is conservative and based only on the PR diff, metadata, and supplied repository context.

Est. cost ~$0.58 (279.1k in / 900 out / gpt-5.6-sol).

<!-- codex-forgejo-review --> <!-- codex-forgejo-review-head:bdf06483e1d286f25c0803e98e66c56dd9ac2ead --> <!-- codex-forgejo-review-comparison:v1:aebf4eba71fb25b5286e7f30a2bb49e060e96d8e5ee36cf2ff2e0dfe6baea2a9 --> ## kReview review **Verdict:** no findings Low risk: the changed pause/resume result reflects the state guaranteed by the successful endpoint, and no concrete regression is established by the visible diff or repository evidence. _Reviewed by kReview at `bdf06483e1`. This comment is conservative and based only on the PR diff, metadata, and supplied repository context._ _Est. cost ~$0.58 (279.1k in / 900 out / gpt-5.6-sol)._ <!-- codex-forgejo-review-state:eyJoZWFkU2hhIjoiYmRmMDY0ODNlMWQyODZmMjVjMDgwM2U5OGU2NmM1NmRkOWFjMmVhZCIsImNvbXBhcmlzb25LZXkiOiJ2MTphZWJmNGViYTcxZmIyNWI1Mjg2ZTdmMzBhMmJiNDllMDYwZTk2ZDhlNWVlMzZjZjJmZjJlMGRmZTZiYWVhMmE5Iiwic3VtbWFyeSI6IkxvdyByaXNrOiB0aGUgY2hhbmdlZCBwYXVzZS9yZXN1bWUgcmVzdWx0IHJlZmxlY3RzIHRoZSBzdGF0ZSBndWFyYW50ZWVkIGJ5IHRoZSBzdWNjZXNzZnVsIGVuZHBvaW50LCBhbmQgbm8gY29uY3JldGUgcmVncmVzc2lvbiBpcyBlc3RhYmxpc2hlZCBieSB0aGUgdmlzaWJsZSBkaWZmIG9yIHJlcG9zaXRvcnkgZXZpZGVuY2UuIiwiZmluZGluZ3MiOltdLCJjdW11bGF0aXZlQ29zdCI6eyJ1c2QiOjAuNTgwNTE0LCJpbnB1dFRva2VucyI6Mjc5MDgzLCJvdXRwdXRUb2tlbnMiOjkwMCwibW9kZWwiOiJncHQtNS42LXNvbCJ9fQ== -->
kleb merged commit 8bdcfffc3f into main 2026-08-30 15:48:36 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
knopersikcuo/Planner!127
No description provided.