Harden memory prompt and relation hygiene #128

Merged
kleb merged 17 commits from feature/harden-memory-post-audit into main 2026-08-30 23:52:08 +02:00
Collaborator

Summary

  • redact high-confidence credential shapes on memory writes and add confirmed targeted prompt replacement
  • stop pending relations from suppressing V2 recall, ignore canonical project names during relation matching, and make candidate judgment explicit
  • prune only truly empty hook sessions, bound CLI session listings, and add cleanup-only orphan repair
  • cover API, CLI, MCP, recall, relation, and lifecycle behavior

Verification

  • bun run check:quality
  • 964 Bun tests passed
  • 238 Vitest tests passed
  • targeted memory suites passed after final lifecycle safeguards
  • blinded 72-run gpt-5.6-luna comparison: base 33/36, feature 35/36, zero base-only wins

The Luna misses were confined to an exact-marker capture grader. Every missed trace still called memory_save successfully and reported completion; all ordinary memory CRUD, retrieval, judgment, pause/resume, and session-end trials passed.

## Summary - redact high-confidence credential shapes on memory writes and add confirmed targeted prompt replacement - stop pending relations from suppressing V2 recall, ignore canonical project names during relation matching, and make candidate judgment explicit - prune only truly empty hook sessions, bound CLI session listings, and add cleanup-only orphan repair - cover API, CLI, MCP, recall, relation, and lifecycle behavior ## Verification - `bun run check:quality` - 964 Bun tests passed - 238 Vitest tests passed - targeted memory suites passed after final lifecycle safeguards - blinded 72-run `gpt-5.6-luna` comparison: base 33/36, feature 35/36, zero base-only wins The Luna misses were confined to an exact-marker capture grader. Every missed trace still called `memory_save` successfully and reported completion; all ordinary memory CRUD, retrieval, judgment, pause/resume, and session-end trials passed.
Collaborator

kReview review

Verdict: no findings

The reviewed changes have low risk; no concrete correctness, security, or lifecycle defect is established by the visible diff and repository evidence.

Reviewed by kReview at ed39fed81d. This comment is conservative and based only on the PR diff, metadata, and supplied repository context.

Est. cost ~$24.93 total (15.6M in / 79.2k out) · this run ~$0.30 (59.5k in / 707 out) / gpt-5.6-sol.

<!-- codex-forgejo-review --> <!-- codex-forgejo-review-head:ed39fed81d506cc603af53166fc4f277791b0f2c --> <!-- codex-forgejo-review-comparison:v1:cc17a9db6095ad439d900c1a6f05af90553c644697c13406fdd317e30a9aaefd --> ## kReview review **Verdict:** no findings The reviewed changes have low risk; no concrete correctness, security, or lifecycle defect is established by the visible diff and repository evidence. _Reviewed by kReview at `ed39fed81d`. This comment is conservative and based only on the PR diff, metadata, and supplied repository context._ _Est. cost ~$24.93 total (15.6M in / 79.2k out) · this run ~$0.30 (59.5k in / 707 out) / gpt-5.6-sol._ <!-- codex-forgejo-review-state:eyJoZWFkU2hhIjoiZWQzOWZlZDgxZDUwNmNjNjAzYWY1MzE2NmZjNGYyNzc3OTFiMGYyYyIsImNvbXBhcmlzb25LZXkiOiJ2MTpjYzE3YTlkYjYwOTVhZDQzOWQ5MDBjMWE2ZjA1YWY5MDU1M2M2NDQ2OTdjMTM0MDZmZGQzMTdlMzBhOWFhZWZkIiwic3VtbWFyeSI6IlRoZSByZXZpZXdlZCBjaGFuZ2VzIGhhdmUgbG93IHJpc2s7IG5vIGNvbmNyZXRlIGNvcnJlY3RuZXNzLCBzZWN1cml0eSwgb3IgbGlmZWN5Y2xlIGRlZmVjdCBpcyBlc3RhYmxpc2hlZCBieSB0aGUgdmlzaWJsZSBkaWZmIGFuZCByZXBvc2l0b3J5IGV2aWRlbmNlLiIsImZpbmRpbmdzIjpbXSwiY3VtdWxhdGl2ZUNvc3QiOnsidXNkIjoyNC45MzQ3MDksImlucHV0VG9rZW5zIjoxNTYxNTYzNSwib3V0cHV0VG9rZW5zIjo3OTE4NCwibW9kZWwiOiJncHQtNS42LXNvbCJ9fQ== -->
kleb merged commit 27ad933372 into main 2026-08-30 23:52:08 +02:00
kleb deleted branch feature/harden-memory-post-audit 2026-08-30 23:52:08 +02:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
knopersikcuo/Planner!128
No description provided.