knopersikcuo/Planner
Watch
1
0
Fork
You've already forked Planner
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Preserve memory relations in account archives #129

Merged
kleb merged 1 commit from fix/memory-archive-capture-integrity into main 2026-08-31 02:45:00 +02:00
Conversation 1 Commits 1 Files changed 18 +575 -72
kleb commented 2026-08-31 02:40:46 +02:00
Collaborator
Copy link

Summary

  • add account archive version 2 with an authenticated memory relation catalog
  • keep version 1 archives readable and normalize their relation count to zero
  • preserve and remap relation graphs across merge and replacement imports
  • commit passive Key Learnings capture as one serializable PostgreSQL transaction
  • invalidate memory caches after commit or rollback and block uncommitted cache publication

Verification

  • two independent Luna benchmark passes reproduced the original defects
  • two independent Luna post-fix reviews found no concrete defect
  • bun run check:quality
    • 971 server and unit tests passed
    • 238 UI tests passed
  • focused failure injection confirms second-write failures leave no durable prefix
  • account archive API tests cover version 1 compatibility, version 2 relation round trips, merge, and replacement
## Summary - add account archive version 2 with an authenticated memory relation catalog - keep version 1 archives readable and normalize their relation count to zero - preserve and remap relation graphs across merge and replacement imports - commit passive Key Learnings capture as one serializable PostgreSQL transaction - invalidate memory caches after commit or rollback and block uncommitted cache publication ## Verification - two independent Luna benchmark passes reproduced the original defects - two independent Luna post-fix reviews found no concrete defect - `bun run check:quality` - 971 server and unit tests passed - 238 UI tests passed - focused failure injection confirms second-write failures leave no durable prefix - account archive API tests cover version 1 compatibility, version 2 relation round trips, merge, and replacement
Make passive capture batches transactional and add rollback coverage.
kAgent commented 2026-08-31 02:40:46 +02:00
Collaborator
Copy link

kReview review

Verdict: no findings

No concrete correctness, security, or data-integrity defects are established by the visible changes and verified repository context.

Reviewed by kReview at f00b5a071c. This comment is conservative and based only on the PR diff, metadata, and supplied repository context.

Est. cost ~$2.68 (1.8M in / 3.9k out / gpt-5.6-sol).

<!-- codex-forgejo-review --> <!-- codex-forgejo-review-head:f00b5a071cf4876f0df3b873a80e1fbed12c3396 --> <!-- codex-forgejo-review-comparison:v1:14123758791be1e64985cfc18232129531835db4874a90118042b13d3bc4c5f8 --> ## kReview review **Verdict:** no findings No concrete correctness, security, or data-integrity defects are established by the visible changes and verified repository context. _Reviewed by kReview at `f00b5a071c`. This comment is conservative and based only on the PR diff, metadata, and supplied repository context._ _Est. cost ~$2.68 (1.8M in / 3.9k out / gpt-5.6-sol)._ <!-- codex-forgejo-review-state:eyJoZWFkU2hhIjoiZjAwYjVhMDcxY2Y0ODc2ZjBkZjNiODczYTgwZTFmYmVkMTJjMzM5NiIsImNvbXBhcmlzb25LZXkiOiJ2MToxNDEyMzc1ODc5MWJlMWU2NDk4NWNmYzE4MjMyMTI5NTMxODM1ZGI0ODc0YTkwMTE4MDQyYjEzZDNiYzRjNWY4Iiwic3VtbWFyeSI6Ik5vIGNvbmNyZXRlIGNvcnJlY3RuZXNzLCBzZWN1cml0eSwgb3IgZGF0YS1pbnRlZ3JpdHkgZGVmZWN0cyBhcmUgZXN0YWJsaXNoZWQgYnkgdGhlIHZpc2libGUgY2hhbmdlcyBhbmQgdmVyaWZpZWQgcmVwb3NpdG9yeSBjb250ZXh0LiIsImZpbmRpbmdzIjpbXSwiY3VtdWxhdGl2ZUNvc3QiOnsidXNkIjoyLjY3NTg3NCwiaW5wdXRUb2tlbnMiOjE3ODA5NjgsIm91dHB1dFRva2VucyI6MzkzMCwibW9kZWwiOiJncHQtNS42LXNvbCJ9fQ== -->
kleb merged commit 6407327821 into main 2026-08-31 02:45:00 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
knopersikcuo/Planner!129
No description provided.